make the agent image 4x smaller thanks to multi stage build#90
Merged
pablogs9 merged 1 commit intomicro-ROS:humblefrom Nov 24, 2022
Merged
make the agent image 4x smaller thanks to multi stage build#90pablogs9 merged 1 commit intomicro-ROS:humblefrom
pablogs9 merged 1 commit intomicro-ROS:humblefrom
Conversation
Member
|
This looks super good @DominikN, we will take a look and merge when we test. |
Member
|
@mergify backport galactic foxy main |
Contributor
✅ Backports have been createdDetails
|
Member
|
Thanks one more time @DominikN |
mergify Bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
(cherry picked from commit 4d0209d) # Conflicts: # base/Dockerfile # micro-ROS-Agent/Dockerfile
mergify Bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
(cherry picked from commit 4d0209d) # Conflicts: # base/Dockerfile # micro-ROS-Agent/Dockerfile
mergify Bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
(cherry picked from commit 4d0209d) # Conflicts: # base/Dockerfile # micro-ROS-Agent/Dockerfile
pablogs9
added a commit
that referenced
this pull request
Nov 24, 2022
…90) (#91) * make the agent image 4x smaller thanks to multi stage build (#90) (cherry picked from commit 4d0209d) # Conflicts: # base/Dockerfile # micro-ROS-Agent/Dockerfile * Fix Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Dominik Nowak <dominik.nwk@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
pablogs9
added a commit
that referenced
this pull request
Nov 24, 2022
…90) (#92) * make the agent image 4x smaller thanks to multi stage build (#90) (cherry picked from commit 4d0209d) # Conflicts: # base/Dockerfile # micro-ROS-Agent/Dockerfile * Fix Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Dominik Nowak <dominik.nwk@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
pablogs9
added a commit
that referenced
this pull request
Nov 24, 2022
…90) (#93) * make the agent image 4x smaller thanks to multi stage build (#90) (cherry picked from commit 4d0209d) # Conflicts: # base/Dockerfile # micro-ROS-Agent/Dockerfile * Fix Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Dominik Nowak <dominik.nwk@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
pablogs9
added a commit
that referenced
this pull request
Dec 12, 2022
…90) (#93) * make the agent image 4x smaller thanks to multi stage build (#90) (cherry picked from commit 4d0209d) # Conflicts: # base/Dockerfile # micro-ROS-Agent/Dockerfile * Fix Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Dominik Nowak <dominik.nwk@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microros/micro-ros-agent:humbleDocker image will be 4 times smaller (1.6GB vs 0.4GB)MICROROS_DISABLE_SHMenv (with default set to1for backward compatibility) allowing you to use your own DDS profile fileYou can test changes with
donowak/micro-ros-agent:humbledocker image (generated from https://github.com/DominikN/micro-ros-agent-minimal)